Thread (5 messages) flat view 5 messages, 3 authors, 2018-06-14

Re: [PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

From: Toshiaki Makita <hidden>
Date: 2018-06-14 00:26:05
Also in: intel-wired-lan

On 2018/06/13 18:06, Daniel Borkmann wrote:
On 06/13/2018 10:08 AM, Toshiaki Makita wrote:
quoted
i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data -
xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary here
and mac_header/data feilds in skb becomes incorrect, and breaks normal
skb receive path as well as XDP receive path.

Fixes: cc5b114dcf98 ("bpf, i40e: add meta data support")
Signed-off-by: Toshiaki Makita <redacted>
Thanks Toshiaki, I sent a complete fix yesterday here:

https://lkml.org/lkml/2018/6/12/843
Oh I was not aware of it. Thanks, let's go with your patch.

-- 
Toshiaki Makita
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help