Re: [PATCH net-next 0/10] xfrm: remove flow cache
From: Kristian Evensen <hidden>
Date: 2018-06-13 13:44:00
From: Kristian Evensen <hidden>
Date: 2018-06-13 13:44:00
Hi, On Wed, Jun 13, 2018 at 2:40 PM, Florian Westphal [off-list ref] wrote:
Can you test attached patch? I'd like to see how much the pcpu cache helps or if it actually hurts in your setup. Subject: [TEST PATCH 4.14.y] xfrm: remove pcpu policy cache We need to re-evaluate if this still buys anything after indirect calls got more expensive (retpolines). When pcpu xdst exists, it has to be validated first (which needs indirect calls). So even if hit rate is good, it might be cheaper to allocate a new xdst entry. Furthermore, the current xdst cache needs to run with BH off, which is also not needed when its removed. Compile tested only.
Thanks! I will prepare a firmware for one of my devices tonight, start testing tomorrow and report back when I have some results. BR, Kristian