Thread (5 messages) flat view 5 messages, 4 authors, 2018-06-15

Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection

From: Eric Dumazet <hidden>
Date: 2018-06-13 04:45:38


On 06/12/2018 04:09 PM, Frank van der Linden wrote:
commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash
table") introduced an optimization for the handling of child sockets
created for a new TCP connection.

But this optimization passes any data associated with the last ACK of the
connection handshake up the stack without verifying its checksum, because it
calls tcp_child_process(), which in turn calls tcp_rcv_state_process()
directly.  These lower-level processing functions do not do any checksum
verification.

Insert a tcp_checksum_complete call in the TCP_NEW_SYN_RECEIVE path to
fix this.

Signed-off-by: Frank van der Linden <redacted>
Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks !
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help