Thread (2 messages) flat view 2 messages, 2 authors, 2018-06-12

Re: [PATCH RFC] tcp: Do not reload skb pointer after skb_gro_receive().

From: Eric Dumazet <hidden>
Date: 2018-06-12 02:59:39


On 06/11/2018 06:00 PM, David Miller wrote:
This is not necessary.  skb_gro_receive() will never change what
'head' points to.

In it's original implementation (see commit 71d93b39e52e ("net: Add
skb_gro_receive")), it did:

====================
+	*head = nskb;
+	nskb->next = p->next;
+	p->next = NULL;
====================

This sequence was removed in commit 58025e46ea2d ("net: gro: remove
obsolete code from skb_gro_receive()")

Signed-off-by: David S. Miller <davem@davemloft.net>
SGTM, thanks David !

Signed-off-by: Eric Dumazet <edumazet@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help