Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum action
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-06-05 21:16:40
On Tue, 5 Jun 2018 16:44:19 -0400 Keara Leibovitz [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/tc/m_csum.c b/tc/m_csum.c index 8391071d73f2..0bdbcf361a28 100644 --- a/tc/m_csum.c +++ b/tc/m_csum.c@@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg) char *uflag_5 = ""; char *uflag_6 = ""; char *uflag_7 = ""; + char buf[64];
Looks good. In iproute2 the common macro for declaring these kind of buffers is: SPRINT_BUF(buf); Doesn't matter that much, but nice to have consistency.