Thread (5 messages) flat view 5 messages, 3 authors, 2018-06-05

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

From: David Miller <davem@davemloft.net>
Date: 2018-06-05 16:46:39

From: Eric Dumazet <edumazet@google.com>
Date: Tue,  5 Jun 2018 09:25:19 -0700
It seems that rtnl_group_changelink() can call do_setlink
while a prior call to validate_linkmsg(dev = NULL, ...) could
not validate IFLA_ADDRESS / IFLA_BROADCAST

Make sure do_setlink() calls validate_linkmsg() instead
of letting its callers having this responsibility.

With help from Dmitry Vyukov, thanks a lot !
 ...
Fixes: e7ed828f10bd ("netlink: support setting devgroup parameters")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <redacted>
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help