Thread (8 messages) 8 messages, 2 authors, 2018-06-04

Re: [PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

From: Igor Russkikh <hidden>
Date: 2018-06-04 23:36:00

quoted
+	mutex_lock(&self->aq_mutex);
+
 	if (aq_utils_obj_test(&self->flags, AQ_NIC_FLAGS_IS_NOT_READY))
 		goto err_exit;
 
@@ -175,6 +177,7 @@ static void aq_nic_service_timer_cb(struct timer_list *t)
 		ctimer = max(ctimer / 2, 1);
 
 err_exit:
+	mutex_unlock(&self->aq_mutex);
 	mod_timer(&self->service_timer, jiffies + ctimer);
 }
 
This looks like a timer callback from the prototype, I don't think you
can take mutexes in timer callbacks.
True as well. Eventually, think we may just get rid of mutex inside of this callback.

Mutex then will only serve to prevent possible parallel `ethtool -G` collisions from happening.

BR, Igor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help