Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps
flat view
From: Jesper Dangaard Brouer <hidden>
Date: 2018-06-03 17:09:03
On Sun, 3 Jun 2018 18:11:45 +0200 Daniel Borkmann [off-list ref] wrote:
On 06/03/2018 08:56 AM, Jesper Dangaard Brouer wrote:quoted
On Sat, 2 Jun 2018 23:06:35 +0200 Daniel Borkmann [off-list ref] wrote:quoted
Before: # bpftool p d x i 1Could this please be changed to: # bpftool prog dump xlated id 1 I requested this before, but you seem to have missed my feedback... This makes the command "self-documenting" and searchable by Google.I recently wrote a howto here, but there's also excellent documentation in terms of man pages for bpftool. http://cilium.readthedocs.io/en/latest/bpf/#bpftool My original thinking was that it might be okay to also show usage of short option matching, like in iproute2 probably few people only write 'ip address' but majority uses 'ip a' instead. But I'm fine either way if there are strong opinions ... thanks Alexei for fixing up!
First of all I love your documentation effort. Secondly I personally *hate* how the 'ip' does it's short options parsing and especially order/precedence ambiguity. Phil Sutter (Fedora/RHEL iproute2 maintainer) have a funny quiz illustrating the ambiguity issues. Quiz: https://youtu.be/cymH9pcFGa0?t=7m10s Code problem: https://youtu.be/cymH9pcFGa0?t=9m8s I hope the maintainers and developers of bpftool make sure we don't end up in an ambiguity mess like we have with 'ip', pretty please. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer