Thread (2 messages) 2 messages, 2 authors, 2018-06-01

Re: [PATCH net-next v2] net: sched: split tc_ctl_tfilter into three handlers

From: David Miller <davem@davemloft.net>
Date: 2018-06-01 15:14:34

From: Vlad Buslov <redacted>
Date: Thu, 31 May 2018 09:52:53 +0300
tc_ctl_tfilter handles three netlink message types: RTM_NEWTFILTER,
RTM_DELTFILTER, RTM_GETTFILTER. However, implementation of this function
involves a lot of branching on specific message type because most of the
code is message-specific. This significantly complicates adding new
functionality and doesn't provide much benefit of code reuse.

Split tc_ctl_tfilter to three standalone functions that handle filter new,
delete and get requests.

The only truly protocol independent part of tc_ctl_tfilter is code that
looks up queue, class, and block. Refactor this code to standalone
tcf_block_find function that is used by all three new handlers.

Signed-off-by: Vlad Buslov <redacted>
---
Changes V1 -> V2:
- Rebase on current net-next
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help