Thread (7 messages) flat view 7 messages, 5 authors, 2018-06-02

Re: [PATCH bpf 1/2] bpf: fix alignment of netns_dev/netns_ino fields in bpf_{map,prog}_info

From: Dmitry V. Levin <hidden>
Date: 2018-05-30 18:19:03
Also in: lkml

On Sun, May 27, 2018 at 01:28:42PM +0200, Eugene Syromiatnikov wrote:
Recent introduction of netns_dev/netns_ino to bpf_map_info/bpf_prog info
has broken compat, as offsets of these fields are different in 32-bit
and 64-bit ABIs.  One fix (other than implementing compat support in
syscall in order to handle this discrepancy) is to use __aligned_u64
instead of __u64 for these fields.

Reported-by: Dmitry V. Levin <redacted>
Fixes: 52775b33bb507 ("bpf: offload: report device information about
offloaded maps")
Fixes: 675fc275a3a2d ("bpf: offload: report device information for
offloaded programs")
Reviewed-by: "Dmitry V. Levin" <redacted>
Cc: <redacted> # v4.16+

Thanks,


-- 
ldv

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help