Re: [PATCH v2] ath6kl: mark expected switch fall-throughs
From: Steve deRosier <hidden>
Date: 2018-05-25 18:28:39
Also in:
linux-wireless, lkml
On Fri, May 25, 2018 at 11:23 AM Gustavo A. R. Silva [off-list ref] wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <redacted> --- Changes in v2: - Place code comments on a line of their own.
drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++ 1 file changed, 3 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c
b/drivers/net/wireless/ath/ath6kl/cfg80211.c
quoted hunk ↗ jump to hunk
index 2ba8cf3..a16ee5d 100644--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c@@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar) switch (ar->hw.cap) { case WMI_11AN_CAP: ht = true; + /* fall through */ case WMI_11A_CAP: band_5gig = true; break; case WMI_11GN_CAP: ht = true; + /* fall through */ case WMI_11G_CAP: band_2gig = true; break; case WMI_11AGN_CAP: ht = true; + /* fall through */ case WMI_11AG_CAP: band_2gig = true; band_5gig = true; --2.7.4
Gustavo, Thanks for the adjustment. It now looks good to me. Reviewed-by: Steve deRosier <redacted>