Re: [PATCH net-next] bpfilter: fix a build err
From: Alexei Starovoitov <hidden>
Date: 2018-05-25 16:19:32
Also in:
lkml
On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote:
quoted hunk ↗ jump to hunk
gcc-7.3.0 report following err: HOSTCC net/bpfilter/main.o In file included from net/bpfilter/main.c:9:0: ./include/uapi/linux/bpf.h:12:10: fatal error: linux/bpf_common.h: No such file or directory #include <linux/bpf_common.h> remove it by adding a include path. Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") Signed-off-by: YueHaibing <redacted> --- net/bpfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile index 2af752c..3f3cb87 100644 --- a/net/bpfilter/Makefile +++ b/net/bpfilter/Makefile@@ -5,7 +5,7 @@ hostprogs-y := bpfilter_umh bpfilter_umh-objs := main.o -HOSTCFLAGS += -I. -Itools/include/ +HOSTCFLAGS += -I. -Itools/include/ -Itools/include/uapi
Strangely I don't see this error with gcc 7.3 I've tried this patch and it doesn't hurt, but before it gets applied could you please try the top two patches from this tree: https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git/?h=ipt_bpf in your environment? These two patches add the actual meat of bpfilter and I'd like to make sure the build setup is good for everyone before we proceed too far.