Re: [PATCH 05/33] cxgb4: use match_string() helper
flat view
From: Andy Shevchenko <hidden>
Date: 2018-05-21 21:39:59
Also in:
lkml
On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie [off-list ref] wrote:
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant.
quoted hunk ↗ jump to hunk
- for (i = 0; i < ARRAY_SIZE(cudbg_region); i++) { - if (!strcmp(cudbg_region[i], region_name)) { - found = 1; - idx = i; - break; - } - } - if (!found) - return -EINVAL; + rc = match_string(cudbg_region, ARRAY_SIZE(cudbg_region), region_name); + if (rc < 0) + return rc; - found = 0; + idx = rc;
Is found still in use after this? If so, is it initialized properly now? -- With Best Regards, Andy Shevchenko