Re: [PATCH] net: qcom/emac: Allocate buffers from local node
From: David Miller <davem@davemloft.net>
Date: 2018-05-17 19:57:05
Also in:
lkml
From: Hemanth Puranik <redacted> Date: Thu, 17 May 2018 13:58:00 +0530
quoted hunk ↗ jump to hunk
Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik <redacted> --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c b/drivers/net/ethernet/qualcomm/emac/emac-mac.c index 092718a..c3df86a 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac-mac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c@@ -684,9 +684,10 @@ static int emac_tx_q_desc_alloc(struct emac_adapter *adpt, { struct emac_ring_header *ring_header = &adpt->ring_header; size_t size; + int node = dev_to_node(adpt->netdev->dev.parent);
Please order local variable declarations from longest to shortest line (ie. reverse christmas tree layout).
quoted hunk ↗ jump to hunk
@@ -725,9 +726,10 @@ static int emac_rx_descs_alloc(struct emac_adapter *adpt) struct emac_ring_header *ring_header = &adpt->ring_header; struct emac_rx_queue *rx_q = &adpt->rx_q; size_t size; + int node = dev_to_node(adpt->netdev->dev.parent);
Likewise.