Wed, May 16, 2018 at 12:00:57PM CEST, vladbu@mellanox.com wrote:

On Wed 16 May 2018 at 09:54, Jiri Pirko [off-list ref] wrote:

quoted

Mon, May 14, 2018 at 04:27:12PM CEST, vladbu@mellanox.com wrote:

quoted

Extend rate estimator new and replace APIs with additional spinlock
parameter used by lockless actions to protect rate_est pointer from
concurrent modification.

Signed-off-by: Vlad Buslov <redacted>

[...]

quoted

/**
 * gen_new_estimator - create a new rate estimator
 * @bstats: basic statistics
 * @cpu_bstats: bstats per cpu
 * @rate_est: rate estimator statistics
+ * @rate_est_lock: rate_est lock (might be NULL)

I cannot find a place you actually use this new arg in this patchset.
Did I miss it?

It is used by specific action init function. However, that code was
moved to next patchset due to patchset size limit.

Please move this patch too.

quoted

quoted

 * @stats_lock: statistics lock
 * @running: qdisc running seqcount
 * @opt: rate estimator configuration TLV

[...]