Thread (3 messages) flat view 3 messages, 3 authors, 2018-05-10

Re: [PATCH v2] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

From: David Miller <davem@davemloft.net>
Date: 2018-05-10 21:47:49
Also in: kernel-janitors, linux-rdma, lkml

From: Christophe JAILLET <redacted>
Date: Thu, 10 May 2018 09:06:04 +0200
If an error occurs, 'mlx4_en_destroy_netdev()' is called.
It then calls 'mlx4_en_free_resources()' which does the needed resources
cleanup.

So, doing some explicit kfree in the error handling path would lead to
some double kfree.

Simplify code to avoid such a case.

Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme")
Signed-off-by: Christophe JAILLET <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help