Thread (4 messages) flat view 4 messages, 2 authors, 2018-05-10

Re: [PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()'

From: Igor Russkikh <hidden>
Date: 2018-05-08 07:19:33
Also in: kernel-janitors, lkml

Hi Christophe,

On 08.05.2018 09:39, Christophe JAILLET wrote:
The position of 2 labels should be swapped in order to release resources
in the correct order and avoid leaks.
 	kfree(self->aq_hw);
 err_ioremap:
 	free_netdev(ndev);
-err_pci_func:
-	pci_release_regions(pdev);
 err_ndev:
+	pci_release_regions(pdev);
+err_pci_func:
 	pci_disable_device(pdev);
 	return err;
 }
This was just submitted yesterday and is already accepted in netdev by David:

http://patchwork.ozlabs.org/patch/909746/

Thanks!

BR, Igor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help