Re: WARNING in kernfs_add_one

On Mon, 2018-05-07 at 11:33 +0200, Dmitry Vyukov wrote:

On Mon, May 7, 2018 at 10:43 AM, Johannes Berg
[off-list ref] wrote:

quoted

On Sat, 2018-05-05 at 15:07 -0700, Greg KH wrote:

quoted

quoted

quoted

quoted

syzbot found the following crash on:

Maybe it should learn to differentiate warnings, if it's going to set
panic_on_warn :-)

How?
Note that this is not specific to syzbot. If you see WARNINGs in a
subsystem that you have no idea about (or you just a normal user),
what do you do? Right, you report it to maintainers.

Yeah, no problem with that. Just some people seem to get so much more
upset about crashes ... but then again I get bug reports about WARN_ON
all the time anyway that say "my kernel crashed" so I guess it doesn't
really matter :-)

quoted

I get why, but still, at least differentiating in the emails wouldn't be
bad.

Well, the subject says "WARNING".
But note there are _very_ bad WARNINGs too. Generally, a WARNING means
a kernel bug just that kernel can tolerate without bringing the system
down (as opposed to BUG).

Yeah, fair point. I sort of missed the subject I guess.

johannes