Re: [RFC PATCH 3/3] arcnet: com20020: Add ethtool support
From: Tobin C. Harding <hidden>
Date: 2018-05-07 03:08:30
Also in:
lkml
On Sat, May 05, 2018 at 11:35:29PM +0200, Andrea Greco wrote:
quoted hunk ↗ jump to hunk
From: Andrea Greco <redacted> Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco <redacted> --- drivers/net/arcnet/com20020-isa.c | 1 + drivers/net/arcnet/com20020-membus.c | 1 + drivers/net/arcnet/com20020.c | 29 +++++++++++++++++++++++++++++ drivers/net/arcnet/com20020.h | 1 + drivers/net/arcnet/com20020_cs.c | 1 + include/uapi/linux/if_arcnet.h | 6 ++++++ 6 files changed, 39 insertions(+)diff --git a/drivers/net/arcnet/com20020-isa.c b/drivers/net/arcnet/com20020-isa.c index 38fa60ddaf2e..44ab6dcccb58 100644 --- a/drivers/net/arcnet/com20020-isa.c +++ b/drivers/net/arcnet/com20020-isa.c@@ -154,6 +154,7 @@ static int __init com20020_init(void) dev->dev_addr[0] = node; dev->netdev_ops = &com20020_netdev_ops; + dev->ethtool_ops = &com20020_ethtool_ops; lp = netdev_priv(dev); lp->backplane = backplane;diff --git a/drivers/net/arcnet/com20020-membus.c b/drivers/net/arcnet/com20020-membus.c index 6e4a2f3a84f7..9eead734a3cf 100644 --- a/drivers/net/arcnet/com20020-membus.c +++ b/drivers/net/arcnet/com20020-membus.c@@ -91,6 +91,7 @@ static int com20020_probe(struct platform_device *pdev) dev = alloc_arcdev(NULL);// Let autoassign name arc%d dev->netdev_ops = &com20020_netdev_ops; + dev->ethtool_ops = &com20020_ethtool_ops; lp = netdev_priv(dev); lp->card_flags = ARC_CAN_10MBIT;/* pretend all of them can 10Mbit */diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index abd32ed8ec9b..2089b45e81c8 100644 --- a/drivers/net/arcnet/com20020.c +++ b/drivers/net/arcnet/com20020.c@@ -201,6 +201,34 @@ const struct net_device_ops com20020_netdev_ops = { .ndo_set_rx_mode = com20020_set_mc_list, }; +static int com20020_ethtool_regs_len(struct net_device *netdev) +{ + return sizeof(struct com20020_ethtool_regs); +} + +static void com20020_ethtool_regs_read(struct net_device *dev, + struct ethtool_regs *regs, void *p) +{ + struct arcnet_local *lp; + struct com20020_ethtool_regs *com_reg; + + lp = netdev_priv(dev); + memset(p, 0, sizeof(struct com20020_ethtool_regs));
perhaps: struct arcnet_local *lp = netdev_priv(dev); struct com20020_ethtool_regs *com_reg = p; memset(com_reg, 0, sizeof(*com_reg));
+ + regs->version = 1;
Should this function really have a side effect? If so, perhaps it could be commented.
+
+ com_reg = p;
+
+ com_reg->status = lp->hw.status(dev) & 0xFF;
+ com_reg->diag_register = (lp->hw.status(dev) >> 8) & 0xFF;
+ com_reg->reconf_count = lp->num_recons;
+}
+
+const struct ethtool_ops com20020_ethtool_ops = {
+ .get_regs = com20020_ethtool_regs_read,
+ .get_regs_len = com20020_ethtool_regs_len,
+};
+Hope this helps, Tobin.