Re: [PATCH net] macsonic: Set platform device coherent_dma_mask
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-05-03 07:26:13
Also in:
lkml
Hi Finn, On Thu, May 3, 2018 at 6:24 AM, Finn Thain [off-list ref] wrote:
Set the device's coherent_dma_mask to avoid a WARNING splat.
Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is
no coherent_dma_mask").
Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <redacted>Thanks for your patch!
quoted hunk
--- a/drivers/net/ethernet/natsemi/macsonic.c +++ b/drivers/net/ethernet/natsemi/macsonic.c@@ -523,6 +523,10 @@ static int mac_sonic_platform_probe(struct platform_device *pdev) struct sonic_local *lp; int err; + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + if (err) + return err; + dev = alloc_etherdev(sizeof(struct sonic_local)); if (!dev) return -ENOMEM;
Shouldn't this be handled in the platform code that instantiates the device,
i.e. in arch/m68k/mac/config.c:mac_platform_init()?
Cfr. commit f61e64310b75733d ("m68k: set dma and coherent masks for platform
FEC ethernets").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds