Re: [PATCH] vhost: make msg padding explicit
From: Kevin Easton <hidden>
Date: 2018-05-02 14:40:19
Also in:
kvm, lkml
On Wed, May 02, 2018 at 05:19:27PM +0300, Michael S. Tsirkin wrote:
On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote:quoted
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Wed, 2 May 2018 16:36:37 +0300quoted
Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't work at all. Hmm. It's relatively new and maybe there aren't any 32 bit users yet. Thoughts?If it's been in a released kernel version, we really aren't at liberty to play "maybe nobody uses this" UAPI changing games. Please send me a revert.Sent. Looking at compat mess now.
Just naming the padding field isn't sufficient anyway, there also needs to
be code in vhost_new_msg() to initialise it using the name.
- Kevin