Re: [PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule
From: David Miller <davem@davemloft.net>
Date: 2018-05-31 19:20:24
From: David Miller <davem@davemloft.net>
Date: 2018-05-31 19:20:24
From: Paul Blakey <redacted> Date: Wed, 30 May 2018 11:29:15 +0300
When we fail to modify a rule, we incorrectly release the idr handle
of the unmodified old rule.
Fix that by checking if we need to release it.
Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure")
Reported-by: Vlad Buslov <redacted>
Reviewed-by: Roi Dayan <redacted>
Acked-by: Jiri Pirko <redacted>
Signed-off-by: Paul Blakey <redacted>Applied and queued up for -stable.