Thread (16 messages) 16 messages, 2 authors, 2018-06-08

Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

From: Nicolas Dichtel <hidden>
Date: 2018-05-31 15:51:19

Le 31/05/2018 à 17:46, Stephen Hemminger a écrit :
On Thu, 31 May 2018 16:28:48 +0200
[snip]
This makes sense. All of linkinfo that is present should be displayed.

Both netns and ifindex are really unsigned values. Use __u32 and print_uint.
Ok.
Also why not convert numeric values to names?
The only case where the ifname can change is when a netns is deleted and the
interface is put back in init_net. But at this stage, we don't know the new name.

For the nsid, you're right, it will be better to display the netns name. If you
agree, I will do this in a following patch, thus all places using nsid can be
converted at the same time.


Regards,
Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help