Thread (2 messages) flat view 2 messages, 2 authors, 2018-05-17

Re: [PATCH] net/ncsi: prevent a couple array underflows

From: David Miller <davem@davemloft.net>
Date: 2018-05-17 20:28:10
Also in: kernel-janitors

From: Dan Carpenter <redacted>
Date: Thu, 17 May 2018 15:33:36 +0300
We recently refactored this code and introduced a static checker
warning.  Smatch complains that if cmd->index is zero then we would
underflow the arrays.  That's obviously true.

The question is whether we prevent cmd->index from being zero at a
different level.  I've looked at the code and I don't immediately see
a check for that.

Fixes: 062b3e1b6d4f ("net/ncsi: Refactor MAC, VLAN filters")
Signed-off-by: Dan Carpenter <redacted>
Applied to net-next, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help