Thread (15 messages) 15 messages, 6 authors, 2018-05-01

Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

From: Eric Dumazet <hidden>
Date: 2018-05-01 19:12:47


On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote:
*sigh* - can do, I guess. Though I'm not sure what that is going to
accomplish, exactly?

I guess that nobody really wants to really review Cake if
it is a file with 2700 lines of code and hundreds of variables/tunables.

Sure, we have big files in networking land, as a result of thousands of changes.

If you split it, then maybe the work can be split among reviewers as a result.

Or maybe David Miller can simply merge your patch as is, and hope for the best,
I really do not know.

It seems you guys spent years/months on work on this stuff, so what is the big deal
about presenting your work in the best possible way ?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help