Thread (2 messages) 2 messages, 2 authors, 2018-05-01

Re: [PATCH net-next V2] cls_flower: Support multiple masks per priority

From: David Miller <davem@davemloft.net>
Date: 2018-05-01 18:14:40

From: Paul Blakey <redacted>
Date: Mon, 30 Apr 2018 14:28:30 +0300
Currently flower doesn't support inserting filters with different masks
on a single priority, even if the actual flows (key + mask) inserted
aren't overlapping, as with the use case of offloading openvswitch
datapath flows. Instead one must go up one level, and assign different
priorities for each mask, which will create a different flower
instances.

This patch opens flower to support more than one mask per priority,
and a single flower instance. It does so by adding another hash table
on top of the existing one which will store the different masks,
and the filters that share it.

The user is left with the responsibility of ensuring non overlapping
flows, otherwise precedence is not guaranteed.

Signed-off-by: Paul Blakey <redacted>
Signed-off-by: Jiri Pirko <redacted>
---

Changes:
V1 -> V2: in fl_init, removed unnessecry err variable, just return direct result instead.
          in fl_mask_range, removed extra new line.
          commit msg, spelling.
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help