Thread (28 messages) 28 messages, 7 authors, 2018-05-07
STALE2967d REVIEWED: 14 (14M)

[PATCH v3 05/20] firewire: Remove depends on HAS_DMA in case of platform dependency

From: Geert Uytterhoeven <hidden>
Date: 2018-04-17 17:49:05
Also in: alsa-devel, linux-block, linux-crypto, linux-fbdev, linux-fpga, linux-i2c, linux-ide, linux-iio, linux-iommu, linux-media, linux-mmc, linux-remoteproc, linux-serial, linux-spi, linux-usb, lkml
Subsystem: firewire subsystem, the rest · Maintainers: Takashi Sakamoto, Linus Torvalds

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
In most cases this other symbol is an architecture or platform specific
symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their
dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
cannot work anyway.

This simplifies the dependencies, and allows to improve compile-testing.

Signed-off-by: Geert Uytterhoeven <redacted>
Reviewed-by: Mark Brown <redacted>
Acked-by: Robin Murphy <redacted>
---
v3:
  - Rebase to v4.17-rc1,

v2:
  - Add Reviewed-by, Acked-by,
  - Drop RFC state,
  - Split per subsystem.
---
 drivers/firewire/Kconfig | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
index 145974f9662b63e6..4199849e37585181 100644
--- a/drivers/firewire/Kconfig
+++ b/drivers/firewire/Kconfig
@@ -1,5 +1,4 @@
 menu "IEEE 1394 (FireWire) support"
-	depends on HAS_DMA
 	depends on PCI || COMPILE_TEST
 	# firewire-core does not depend on PCI but is
 	# not useful without PCI controller driver
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help