Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info
From: David Ahern <hidden>
Date: 2018-04-16 19:26:07
On 4/16/18 1:20 PM, David Miller wrote:
From: David Ahern <redacted> Date: Mon, 16 Apr 2018 08:22:41 -0700quoted
@@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev) .fc_ifindex = dev->ifindex, .fc_dst_len = 8, .fc_flags = RTF_UP, + .fc_type = RTN_UNICAST, .fc_nlinfo.nl_net = dev_net(dev), };Multicast route is of type RTN_UNICAST?
The ff00::/8 route is. Today's code: # ip -d -6 ro ls table local .. unicast ff00::/8 dev eth3 proto boot scope global metric 256 pref medium unicast ff00::/8 dev eth4 proto boot scope global metric 256 pref medium With this patch set: # ip -d -6 ro ls table local ... unicast ff00::/8 dev eth3 proto boot scope global metric 256 pref medium unicast ff00::/8 dev eth4 proto boot scope global metric 256 pref medium
All of these cases where passing in a zero initialized value of fc_type up until this patch. Perhaps you should discuss that in your commit message a little bit.
ok