Re: [PATCH net-next v2] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms
From: Simon Horman <horms@verge.net.au>
Date: 2018-04-09 07:16:27
Also in:
lvs-devel
From: Simon Horman <horms@verge.net.au>
Date: 2018-04-09 07:16:27
Also in:
lvs-devel
On Sun, Apr 01, 2018 at 02:11:51PM +0300, Julian Anastasov wrote:
Hello, On Sun, 1 Apr 2018, Vincent Bernat wrote:quoted
The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative hashing incorrectly. Replace its use by the hash_32() macro, which correctly implements this algorithm. It doesn't use the same constant, but it shouldn't matter. Signed-off-by: Vincent Bernat <redacted>Looks good to me, thanks! Simon, please apply, if possible with the extra space removed, see below... Acked-by: Julian Anastasov <ja@ssi.bg>
Thanks, I have applied this with the extra space removed. I will submit it for inclusion in v4.18.