Thread (3 messages) 3 messages, 3 authors, 2018-03-22

Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

flat view

From: David Miller <davem@davemloft.net>
Date: 2018-03-22 18:53:10
Also in: kernel-janitors, lkml

From: Colin King <redacted>
Date: Wed, 21 Mar 2018 19:34:58 +0000
From: Colin Ian King <redacted>

The current logic of flags | TUNNEL_SEQ is always non-zero and hence
sequence numbers are always incremented no matter the setting of the
TUNNEL_SEQ bit.  Fix this by using & instead of |.

Detected by CoverityScan, CID#1466039 ("Operands don't affect result")

Fixes: 77a5196a804e ("gre: add sequence number for collect md mode.")
Signed-off-by: Colin Ian King <redacted>
Applied, thanks Colin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help