Re: [PATCH v2] net: netfilter: Replace printk() with appropriate pr_*() macro

Arushi Singhal [off-list ref] wrote:

On Mon, Mar 12, 2018 at 2:17 AM, Pablo Neira Ayuso [off-list ref]
wrote:

quoted

Hi Joe,

On Sun, Mar 11, 2018 at 12:52:41PM -0700, Joe Perches wrote:

quoted

On Mon, 2018-03-12 at 01:11 +0530, Arushi Singhal wrote:

quoted

Using pr_<loglevel>() is more concise than
printk(KERN_<LOGLEVEL>).
Replace printks having a log level with the appropriate
pr_*() macros.

Signed-off-by: Arushi Singhal <redacted>
---
changes in v2
*in v1 printk() were replaced with netdev_*()

quoted

 net/netfilter/nf_conntrack_acct.c      | 2 +-
 net/netfilter/nf_conntrack_ecache.c    | 2 +-
 net/netfilter/nf_conntrack_timestamp.c | 2 +-
 net/netfilter/nf_nat_core.c            | 2 +-
 net/netfilter/nfnetlink_queue.c        | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

None of these files have a #define for pr_fmt so this
should be OK.

I think Arushi could add pr_fmt in the same go, so we skip another
follow up patch for this. @Arushi: I suggested this in my previous
email, please have a look.

Hello Pablo

Should I send two patches, one with the conversion of printk() to pr_() and
another for defining pr_fmt().

Or

only one patch with all the changes?

Both in one, it reduces code churn.

With pr_* + pr_fmt, the module name will be prefixed automatically, see
e.g. commit e016c5e43db51875c2b541b59bd217494d213174 as an example.

quoted

This would also probably allows us to save the line break in the error
message, which IIRC is not a good practise either, eg.

                                pr_warn("nf_queue: OOM "
                                        "in mangle, dropping packet\n");

quoted

Perhaps coalesce the formats and remove the unnecessary periods too.

The above message should be removed, its useless (on oom allocator
already warns).