Re: [Outreachy kernel] [PATCH] net: ethernet: Drop unnecessary continue
flat view
From: Julia Lawall <hidden>
Date: 2018-03-03 14:06:43
Also in:
lkml
On Sat, 3 Mar 2018, Arushi Singhal wrote:
Continue at the bottom of a loop are removed. Issue found using drop_continue.cocci Coccinelle script.
In each case you leave an if with a single statement in the branch. In
that case the { } should be dropped too.
julia
quoted hunk ↗ jump to hunk
Signed-off-by: Arushi Singhal <redacted> --- drivers/net/ethernet/amd/ni65.c | 1 - drivers/net/ethernet/neterion/s2io.c | 1 - drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 1 - 3 files changed, 3 deletions(-)diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c index e248d1a..5975f29 100644 --- a/drivers/net/ethernet/amd/ni65.c +++ b/drivers/net/ethernet/amd/ni65.c@@ -437,7 +437,6 @@ static int __init ni65_probe1(struct net_device *dev,int ioaddr) for(j=0;j<3;j++) if(inb(ioaddr+cards[i].addr_offset+j) != cards[i].vendor_id[j]) { release_region(ioaddr, cards[i].total_size); - continue; } } break;diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index b8983e7..5123abd 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c@@ -3682,7 +3682,6 @@ static void restore_xmsi_data(struct s2io_nic *nic) if (wait_for_msix_trans(nic, msix_index)) { DBG_PRINT(ERR_DBG, "%s: index: %d failed\n", __func__, msix_index); - continue; } } }diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c index 15fa47f..77916ed 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c@@ -260,7 +260,6 @@ nfp_net_pf_alloc_vnics(struct nfp_pf *pf, void __iomem *ctrl_bar, /* Kill the vNIC if app init marked it as invalid */ if (nn->port && nn->port->type == NFP_PORT_INVALID) { nfp_net_pf_free_vnic(pf, nn); - continue; } } --2.7.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. To post to this group, send email to outreachy-kernel@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303130933.GA8337%40seema-Inspiron-15-3567. For more options, visit https://groups.google.com/d/optout.