Re: [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
flat view
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-03-04 13:29:01
Also in:
lkml
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote:
quoted hunk ↗ jump to hunk
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>). Replace printks having a log level with the appropriate pr_*() macros. Signed-off-by: Arushi Singhal <redacted> --- drivers/staging/ipx/af_ipx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c index d21a9d1..27f4461 100644 --- a/drivers/staging/ipx/af_ipx.c +++ b/drivers/staging/ipx/af_ipx.c@@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc, intrfc->if_netnum = cb->ipx_source_net; ipxitf_add_local_route(intrfc); } else { - printk(KERN_WARNING "IPX: Network number collision " + pr_warn("IPX: Network number collision "
It is a driver, so it would be best to use dev_warn() or even better yet, net_warn(). Please try to make that change instead. thanks, greg k-h