Thread (3 messages) 3 messages, 3 authors, 2018-03-05

Re: [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

flat view

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-03-05 06:01:21
Also in: lkml

On Mon, Mar 05, 2018 at 09:47:40AM +0530, Arushi Singhal wrote:
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.

Signed-off-by: Arushi Singhal <redacted>
---
changes in v2
*In v1 printk was changed to pr_*macro(), which is used
in kernel instead of calling printk() directly. And for drivers,
dev_*macro() or net_*macro_ratelimited() should be used for calling
printk() directly.

changes in v3
*Indentation is not changed, as line is exceeding 80 characters limit.

 drivers/staging/ipx/af_ipx.c | 2 +-
Did you read drivers/staging/ipx/TODO?

Please go do so.

sorry,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help