Re: [PATCH v5 0/2] Remove false-positive VLAs when using max()
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-03-16 20:14:17
Also in:
linux-input, lkml
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-03-16 20:14:17
Also in:
linux-input, lkml
On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda [off-list ref] wrote:
quoted
Kees - is there some online "gcc-4.4 checker" somewhere? This does seem to work with my gcc. I actually tested some of those files you pointed at now.I use this one: https://godbolt.org/
Well, my *test* code works on that one and -Wvla -Werror.
It does not work with gcc-4.1.x, but works with gcc-4.4.x.
I can't seem to see the errors any way, I wonder if
__builtin_choose_expr() simply didn't exist back then.
Odd that you can't view warnings/errors with it.
But it's possible that it fails on more complex stuff in the kernel.
I've done a "allmodconfig" build with that patch, and the only issue
it found was that (real) type issue in tpm_tis_core.h.
Linus