Thread (8 messages) 8 messages, 3 authors, 2018-03-12

Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

flat view

From: David Miller <davem@davemloft.net>
Date: 2018-03-07 16:23:45

From: Paul Blakey <redacted>
Date: Wed,  7 Mar 2018 16:00:11 +0200
On our mlx5 driver fs_core.c, we use the rhltable interface to store
flow groups. We noticed that sometimes we get a warning that flow group isn't
found at removal. This rare case was caused when a specific scenario happened,
insertion of a flow group with a similar match criteria (a duplicate),
but only where the flow group rhash_head was second (or not first)
on the relevant rhashtable bucket list.

The first patch fixes it, and the second one adds a test that show
it is now working.

Paul.

v4 --> v3 changes:
    * Added Herbert Xu's ack (thanks)
    * Removed extra commit tags
I already applied v3, sorry.  But I did add Herbert's ACKs.
:-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help