Thread (13 messages) 13 messages, 4 authors, 2018-03-09

Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

flat view

From: Jakub Kicinski <hidden>
Date: 2018-03-09 07:36:13

On Thu, 8 Mar 2018 21:10:59 -0800, Alexei Starovoitov wrote:
On Thu, Mar 8, 2018 at 2:00 PM, Jiri Benc [off-list ref] wrote:
quoted
Currently, 'make bpf' in the tools/ directory does not provide the standard
quiet output except for bpftool (which is however listed with a wrong
directory). Worse, it does not respect the build output directory.

The 'make bpf_install' does not work as one would expect, either. It
installs unconditionally to /usr/bin without respecting DESTDIR and prefix.

This patchset improves that behavior.  
Jakub,
please review this set.

Thanks!
I stared at it for a while, and it looks good!

Reviewed-by: Jakub Kicinski <redacted>

In addition I found a GCC 7 warning in bpftool, .PHONY lacks some
targets and we don't clean up after feature detection.  I'll send
patches for that unless someone beats me to it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help