Re: [PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset

On Mar 14, 2018, at 5:29 PM, Daniel Borkmann [off-list ref] wrote:

On 03/14/2018 06:23 PM, Song Liu wrote:

quoted

Changes v4 -> v6:

1. When kernel stack is added to stackmap with build_id, use fallback
  mechanism to store ip (status == BPF_STACK_BUILD_ID_IP).

Changes v4 -> v5:

1. Only allow build_id lookup in non-nmi context. Added comment and
  commit message to highlight this limitation.
2. Minor fix reported by kbuild test robot.

Changes v3 -> v4:

1. Add fallback when build_id lookup failed. In this case, status is set
  to BPF_STACK_BUILD_ID_IP, and ip of this entry is saved.
2. Handle cases where vma is only part of the file (vma->vm_pgoff != 0).
  Thanks to Teng for helping me identify this issue!
3. Address feedbacks for previous versions.

Applied to bpf-next, thanks Song!

P.s.: In the merge commit I included your description from the original
v1 cover letter to provide readers with some more context. Please don't
remove such things in future from cover letter. Only the above doesn't
really say much about the series overall.

Get it! Thanks Daniel!

Best,
Song