Thread (25 messages) 25 messages, 3 authors, 2018-03-20

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

From: Tariq Toukan <hidden>
Date: 2018-03-20 08:18:12

quoted
I see the issue.  I have to go over the details in the driver, but I
think it should be sufficient to remove the WARN().  When the page_pool
was integrated with the MM-layer, being invoked from the put_page()
call itself, this would indicate a likely API misuse.  But now, with
the page refcnt based recycle tricks, it is the norm (for non-XDP) that
put_page is called without the knowledge of page_pool.
I see, I'll remove the WARN and test.
Verified, it works. Please fix in next patchset.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help