Re: [PATCH v2 2/2] i40e: add support for XDP_REDIRECT

On Thu, Mar 22, 2018 at 5:20 AM, Björn Töpel [off-list ref] wrote:

2018-03-22 12:58 GMT+01:00 Jesper Dangaard Brouer [off-list ref]:

quoted

On Thu, 22 Mar 2018 10:03:07 +0100 Björn Töpel [off-list ref] wrote:

quoted

+/**
+ * i40e_xdp_xmit - Implements ndo_xdp_xmit
+ * @dev: netdev
+ * @xdp: XDP buffer
+ *
+ * Returns Zero if sent, else an error code
+ **/
+int i40e_xdp_xmit(struct net_device *dev, struct xdp_buff *xdp)
+{

The return code is used by the XDP redirect tracepoint... this is the
only way we have to debug/troubleshoot runtime issues with XDP. Thus,
these need to be consistent across drives and distinguishable.

Thanks for pointing this out! I'll address all your comments and do a
respin (but I'll wait for Alex' comments, if any).


Björn

The patch mostly looks okay to me. Maybe a bit of reverse xmas tree
formatting needs to be addressed for the variable declarations in your
two new functions but that is about it in terms of what I see.

- Alex