Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device
From: Richard Cochran <richardcochran@gmail.com>
Date: 2018-03-30 15:21:24
From: Richard Cochran <richardcochran@gmail.com>
Date: 2018-03-30 15:21:24
On Fri, Mar 30, 2018 at 05:02:14PM +0200, Andrew Lunn wrote:
Would it not be better to just call ethtool_get_ts_info() on the real device? That would then also deal with the case that the 'real' device is another virtual device stacked on top of a real device.
That won't work. The returned 'ethtool_ts_info' is on the stack of ethtool_get_ts_info(). Both the top level and the inner call to will call copy_to_user(), but the top level will clobber the correct result with zeros. Thanks, Richard