Re: [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload infrastructure

On Tue, Mar 27, 2018 at 3:26 PM, Dave Watson [off-list ref] wrote:

Thanks for doing the merge, it looks good to me.  One issue below,
otherwise all my SW tests still pass.

On 03/27/18 02:51 PM, Saeed Mahameed wrote:

quoted

-     if (ctx->conf == TLS_SW_TX ||
-         ctx->conf == TLS_SW_RX ||
-         ctx->conf == TLS_SW_RXTX) {
-             tls_sw_free_resources(sk);
+     if (ctx->rx_conf == TLS_SW) {
+             kfree(ctx->rx.rec_seq);
+             kfree(ctx->rx.iv);
+             tls_sw_free_resources_rx(sk);
      }

+     if (ctx->tx_conf != TLS_HW)
+             kfree(ctx);

Looks like this needs to be hidden behind CONFIG_TLS_DEVICE, otherwise
it doesn't compile if false because TLS_HW is not defined

Correct, Will fix.

Thanks Dave !