Thread (4 messages) 4 messages, 2 authors, 2018-03-27

Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values

flat view

From: Roman Mashak <hidden>
Date: 2018-03-27 21:33:06

Stephen Hemminger [off-list ref] writes:
On Mon, 19 Mar 2018 17:05:41 -0400
Roman Mashak [off-list ref] wrote:
quoted
diff --git a/tc/m_gact.c b/tc/m_gact.c
index 16c4413f4217..52022415db48 100644
--- a/tc/m_gact.c
+++ b/tc/m_gact.c
@@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg)
 	print_string(PRINT_ANY, "random_type", "\n\t random type %s",
 		     prob_n2a(pp->ptype));
 	print_action_control(f, " ", pp->paction, " ");
-	print_int(PRINT_ANY, "val", "val %d", pp->pval);
+	print_int(PRINT_ANY, "val", "val %u", pp->pval);
 	close_json_object();
This needs to be print_uint in order to work correctly with json output.

Also, please consider doing json on all the match types in a later patch
for net-next.
Did you mean iproute2-next?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help