Re: [PATCH net-next] XDP router for veth

On Mon, Mar 26, 2018 at 9:01 PM, Md. Islam [off-list ref] wrote:

On Mon, Mar 26, 2018 at 10:21 AM, David Miller [off-list ref] wrote:

quoted

From: "Md. Islam" <redacted>
Date: Fri, 23 Mar 2018 02:43:16 -0400

quoted

+#ifdef CONFIG_XDP_ROUTER
+        //if IP forwarding is enabled on the receiver, create xdp_buff
+        //from skb and call xdp_router_forward()

Never use C++ comments, only use C style.

quoted

+        if(is_forwarding_enabled(rcv)){

There must be a space between 'if' and the openning parenthesis.  You need
to also have a space before the openning curly braces.

In fact this entire patch is full of coding style issues, please run your
changes through checkpatch.pl before resubmitting.

Thanks David for the suggestions! I fixed all the formating errors. I
also modified the forwarding logic. Now the iperf throughput improved
from
53.8Gb/s to around 60Gb/s and the median RTT improved from .055 ms to
.35 ms. The patch is attached.

Sorry, the RTT improved from .055 ms to .035 ms.