Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift
From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-02-15 20:28:05
Also in:
kernel-janitors, lkml
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c b/drivers/net/dsa/mv88e6xxx/hwtstamp.c index b251d534b70d..758e35fa69ab 100644 --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c@@ -321,7 +321,7 @@ static void mv88e6xxx_get_rxts(struct mv88e6xxx_chip *chip, */ for ( ; skb; skb = skb_dequeue(rxq)) { if (mv88e6xxx_ts_valid(status) && seq_match(skb, seq_id)) { - u64 ns = timehi << 16 | timelo; + u64 ns = (u64)timehi << 16 | timelo;
Hi Richard Do you prefer this, or making timehi and timelo a u64? Andrew