Re: [PATCH net v4 01/13] net/8390: Remove redundant make dependencies
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-02-12 08:16:48
Also in:
linux-m68k, lkml
On Mon, Feb 12, 2018 at 4:08 AM, Finn Thain [off-list ref] wrote:
The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and have no need for 8390.o. modinfo confirms no dependency on 8390.ko. Drop the redundant dependency from the Makefile. objdump confirms that this has no effect on the module binaries. Cc: Greg Ungerer <gerg@linux-m68k.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Finn Thain <redacted>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
The superfluous additions of 8390.o were introduced in commit
644570b830266ff3 ("8390: Move the 8390 related drivers").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds