Thread (5 messages) flat view 5 messages, 3 authors, 2018-02-09

Re: net: thunder: change q_len's type to handle max ring size

From: Dean Nelson <hidden>
Date: 2018-02-09 12:52:04
Also in: linux-arm-kernel, lkml

On 02/08/2018 10:29 PM, Sunil Kovvuri wrote:
On Fri, Feb 9, 2018 at 3:27 AM, Dean Nelson [off-list ref] wrote:
quoted
On 02/08/2018 02:34 PM, David Miller wrote:
quoted
From: Dean Nelson <redacted>
Date:
quoted
The Cavium thunder nicvf driver supports rx/tx rings of up to 65536
entries per.
  ...
quoted
quoted
Another way to solve this could have been to encode that length
as "length - 1"

True. I had pondered that, but felt that since changing q_len's type
didn't add any length to the structure and that it was less impactful
from a number-of-lines of code changed perspective, I'd opt for this
route.

Cavium, if you'd prefer this goes the route that Dave just mentioned,
please let me know and I can make a new patch against what's been
applied?
Thanks for fixing this and i think the current patch is fine.
You're welcome. And thanks for responding. So I'll leave things as they
are.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help