Thread (2 messages) flat view 2 messages, 2 authors, 2018-02-08

Re: [PATCH] net: Extra '_get' in declaration of arch_get_platform_mac_address

From: David Miller <davem@davemloft.net>
Date: 2018-02-08 20:14:33
Also in: lkml

From: Mathieu Malaterre <redacted>
Date: Wed,  7 Feb 2018 20:35:00 +0100
In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."),
two declarations were added:

  int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
  unsigned char *arch_get_platform_get_mac_address(void);

An extra '_get' was introduced in arch_get_platform_get_mac_address, remove
it. Fix compile warning using W=1:

  CC      net/ethernet/eth.o
net/ethernet/eth.c:523:24: warning: no previous prototype for ‘arch_get_platform_mac_address’ [-Wmissing-prototypes]
 unsigned char * __weak arch_get_platform_mac_address(void)
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  AR      net/ethernet/built-in.o

Signed-off-by: Mathieu Malaterre <redacted>
I'm very surprised this warning didn't get triggered before.

That's really weird!

Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help