Thread (5 messages) flat view 5 messages, 2 authors, 2018-02-08

Re: [PATCH net] ptr_ring: fail early if queue occupies more than KMALLOC_MAX_SIZE

From: Jason Wang <hidden>
Date: 2018-02-07 09:18:08
Also in: lkml


On 2018年02月07日 16:08, Jason Wang wrote:
quoted hunk ↗ jump to hunk
To avoid slab to warn about exceeded size, fail early if queue
occupies more than KMALLOC_MAX_SIZE.

Reported-by: syzbot+e4d4f9ddd4295539735d@syzkaller.appspotmail.com
Signed-off-by: Jason Wang <redacted>
---
  include/linux/ptr_ring.h | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
index 1883d61..4b862da 100644
--- a/include/linux/ptr_ring.h
+++ b/include/linux/ptr_ring.h
@@ -466,6 +466,8 @@ static inline int ptr_ring_consume_batched_bh(struct ptr_ring *r,
  
  static inline void **__ptr_ring_init_queue_alloc(unsigned int size, gfp_t gfp)
  {
+	if (size > KMALLOC_MAX_SIZE)
+		return NULL;
  	return kcalloc(size, sizeof(void *), gfp);
  }
  
Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers")
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help