Thread (2 messages) flat view 2 messages, 2 authors, 2018-02-03

Re: [PATCH] net: qed: use correct strncpy() size

From: David Miller <davem@davemloft.net>
Date: 2018-02-03 00:43:22
Also in: lkml

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri,  2 Feb 2018 16:44:47 +0100
passing the strlen() of the source string as the destination
length is pointless, and gcc-8 now warns about it:

drivers/net/ethernet/qlogic/qed/qed_debug.c: In function 'qed_grc_dump':
include/linux/string.h:253: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]

This changes qed_grc_dump_big_ram() to instead uses the length of
the destination buffer, and use strscpy() to guarantee nul-termination.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help